Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tool for dumping feature status based on tidy #135662

Closed
wants to merge 4 commits into from
Closed

Add new tool for dumping feature status based on tidy #135662

wants to merge 4 commits into from

Conversation

yaahc
Copy link
Member

@yaahc yaahc commented Jan 17, 2025

sequel to #133514

meaning ...

supercedes #133351

part of #129485

r? @jieyouxu
cc @estebank

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

jieyouxu
jieyouxu reviewed Jan 18, 2025
View reviewed changes
src/tools/tidy/Cargo.toml
@@ -12,6 +12,7 @@ miropt-test-tools = { path = "../miropt-test-tools" }
walkdir = "2"
ignore = "0.4.18"
semver = "1.0"
serde = { version = "1.0.125", features = [ "derive" ] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: should this be gated behind like a build-metrics cargo feature? I ask because tidy is built very often (many people have pre-push hooks that will run tidy) so build time is important.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye I can totally do that, that sounds like a good idea to me.

@jieyouxu
Copy link
Member

(The lockfile might need bumping)

@yaahc
Copy link
Member Author

yaahc commented Jan 18, 2025

dangit because I opened the PR directly from your branch rather than pulling to my fork and creating a branch based off of it I don't have permissions to edit it anymore x_X. I'm gonna take a break here and probably reopen this PR again on monday, I'll handle the check / lockfile / build time issues then.

@jieyouxu
Copy link
Member

No rush!
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2025
@jieyouxu jieyouxu added the A-metrics Area: Metrics label Jan 18, 2025
@yaahc
Copy link
Member Author

yaahc commented Jan 21, 2025

reopened as #135844

@yaahc yaahc closed this Jan 21, 2025
@jieyouxu jieyouxu deleted the pr-133514 branch March 7, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@jieyouxu jieyouxu

Labels
A-metrics Area: Metrics A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaahc @rustbot @rust-log-analyzer @jieyouxu