rustc_resolve: use structured fields in traces #135676
Open
+19
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Jan 18, 2025
| "find_span_immediately_after_crate_name: module_name={:?} use_span={:?}", | ||
| module_name, use_span | ||
| ); | ||
| debug!("find_span_immediately_after_crate_name",); |
There was a problem hiding this comment.
there's no need to repeat the name of the function here and elsewhere; please remove.
There was a problem hiding this comment.
What do you think should be the message instead? Something like debug!("entered")?
(in the places where fields are added I can just remove the message)
There was a problem hiding this comment.
not totally certain that they're even adding much value to keep around at all.
There was a problem hiding this comment.
Removed those, then. (and the instrumentation for the containing fns)
yotamofek
force-pushed
the
resolve-cleanups
branch
from
7079452 to
1dc6b91
Compare
yotamofek
force-pushed
the
resolve-cleanups
branch
from
1dc6b91 to
a70ca63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this crate was written before
tracingwas adopted, and was manually writing fields into trace logs instead of using structured fields.I kept function names in the trace messages even though I added
#[instrument]invocations so that the events will be in named spans, wasn't sure if spans are always printed.