Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: move io module out of pal, get rid of sys_common::io #135696

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

std: move io module out of pal, get rid of sys_common::io #135696

wants to merge 2 commits into from

Conversation

joboet
Copy link
Member

@joboet joboet commented Jan 18, 2025 •
edited
Loading

Part of #117276.

This does two related things:

  1. It moves the platform-specific definitions for IoSlice, IoSliceMut and is_terminal out of pal and into sys and unifies some of them.
  2. It gets rid of sys_common::io, moving the non-platform-specific test helpers into std::test_helpers and the buffer size definition to the new sys::io module.

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 18, 2025
@joboet joboet mentioned this pull request Jan 18, 2025
Open
fbstj
fbstj reviewed Jan 18, 2025
View reviewed changes
library/std/src/sys/io/io_slice/iovec.rs
Comment on lines +9 to +10
#[cfg(target_os = "solid_asp3")]
use crate::sys::pal::abi::sockets::iovec;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be at the top of the file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustfmt moves it here because it's an import from crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

Assignees

@Noratrieb Noratrieb

Labels
O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joboet @rustbot @fbstj @Noratrieb