Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf test for the parallel front end #139161

Closed
wants to merge 1 commit into from

Conversation

SparrowLii
Copy link
Member

Perf test for the parallel front end
r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 31, 2025
@SparrowLii
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 31, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2025
Perf test for the parallel front end

Perf test for the parallel front end
r? `@ghost`
@bors
Copy link
Collaborator

bors commented Mar 31, 2025

⌛ Trying commit 1b486d3 with merge d15cb3d...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
tests/ui/ref_option/ref_option.all.fixed ... ok
tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.fixed ... ok

FAILED TEST: tests/ui/unconditional_recursion.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps" "--extern=clippy_config=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_config-f70fcb0bca23d4c7.rlib" "--extern=clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-8810885a8b0f7677.rlib" "--extern=clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-3b75e80d1d679bda.rlib" "--extern=futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-208855c7656dd2cf.rlib" "--extern=if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-d494e6b7c1a6e89b.rlib" "--extern=itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-22c8a3ae2ecf5885.rlib" "--extern=parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-ad691604c4582e99.rlib" "--extern=quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libquote-78ae6387337c7dd5.rlib" "--extern=regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libregex-75c78277780d7d9c.rlib" "--extern=serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libserde-4d5c3dc88b671e13.rlib" "--extern=serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libserde_derive-1d96f4727bf43663.so" "--extern=syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-24bc526a2407e76e.rlib" "--extern=tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-e3cdfdef09766281.rlib" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/release/deps" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/ui_test/0/tests/ui" "tests/ui/unconditional_recursion.rs" "--edition" "2021"

error: actual output differed from expected
Execute `cargo uibless` to update `tests/ui/unconditional_recursion.stderr` to the actual output
--- tests/ui/unconditional_recursion.stderr
+++ <stderr output>
 error: function cannot return without recursing
-  --> tests/ui/unconditional_recursion.rs:51:5
+  --> tests/ui/unconditional_recursion.rs:56:5
    |
-LL |     fn ne(&self, other: &Self) -> bool {
+LL |     fn eq(&self, other: &Self) -> bool {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
 ...
-LL |         self.ne(other)
+LL |         self.eq(other)
    |         -------------- recursive call site
    |
... 3 lines skipped ...
 
 error: function cannot return without recursing
-  --> tests/ui/unconditional_recursion.rs:56:5
+  --> tests/ui/unconditional_recursion.rs:51:5
    |
-LL |     fn eq(&self, other: &Self) -> bool {
+LL |     fn ne(&self, other: &Self) -> bool {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
 ...
-LL |         self.eq(other)
+LL |         self.ne(other)
    |         -------------- recursive call site
    |
... 360 lines skipped ...
 error: aborting due to 27 previous errors
 

Full unnormalized output:
error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:56:5
   |
LL |     fn eq(&self, other: &Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
...
LL |         self.eq(other)
   |         -------------- recursive call site
   |
   = help: a `loop` may express intention better if this is on purpose
   = note: `-D unconditional-recursion` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unconditional_recursion)]`

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:51:5
   |
LL |     fn ne(&self, other: &Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
...
LL |         self.ne(other)
   |         -------------- recursive call site
   |
   = help: a `loop` may express intention better if this is on purpose

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:235:5
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:22:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         self == other
LL | |     }
   | |_____^
---
##[error]  --> tests/ui/unconditional_recursion.rs:35:5
   |
LL | /     fn ne(&self, other: &Self) -> bool {
LL | |
LL | |         self != &Foo2::B // no error here
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:37:9
   |
LL |         self != &Foo2::B // no error here
   |         ^^^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:39:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |         self == &Foo2::B // no error here
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:41:9
   |
LL |         self == &Foo2::B // no error here
   |         ^^^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:51:5
   |
LL | /     fn ne(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         self.ne(other)
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:54:9
   |
LL |         self.ne(other)
   |         ^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:56:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
...  |
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:60:9
   |
LL |         self.eq(other)
   |         ^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:102:5
   |
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:107:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         other == self
LL | |     }
   | |_____^
---
   |
LL |         other != other
   |         ^^^^^^^^^^^^^^
   |
   = note: `#[deny(clippy::eq_op)]` on by default

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:124:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         other == other
LL | |
LL | |     }
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:135:5
   |
LL | /     fn ne(&self, _other: &Self) -> bool {
LL | |
LL | |
LL | |         self != self
LL | |
LL | |     }
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:141:5
   |
LL | /     fn eq(&self, _other: &Self) -> bool {
LL | |
LL | |
LL | |         self == self
LL | |
LL | |     }
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:171:13
   |
LL | /             fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |                 self == other
LL | |             }
   | |_____________^
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:201:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         let mine = &self.field;
LL | |         let theirs = &other.field;
LL | |         mine == theirs
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:206:9
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:311:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         let mine = &self.field;
LL | |         let theirs = &other.field;
LL | |         mine.eq(theirs)
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:316:9
   |
LL |         mine.eq(theirs)
   |         ^^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:383:5
   |
LL | /     fn from(f: BadFromTy1<'a>) -> Self {
LL | |
LL | |         f.into()
LL | |     }
   | |_____^
   |
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:393:5
   |
LL | /     fn from(f: BadFromTy2<'a>) -> Self {
LL | |
LL | |         Into::into(f)
LL | |     }
   | |_____^
   |
---
full stderr:
error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:56:5
   |
LL |     fn eq(&self, other: &Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
...
LL |         self.eq(other)
   |         -------------- recursive call site
   |
   = help: a `loop` may express intention better if this is on purpose
   = note: `-D unconditional-recursion` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unconditional_recursion)]`

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:51:5
   |
LL |     fn ne(&self, other: &Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
...
LL |         self.ne(other)
   |         -------------- recursive call site
   |
   = help: a `loop` may express intention better if this is on purpose

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:235:5
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:22:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         self == other
LL | |     }
   | |_____^
---
##[error]  --> tests/ui/unconditional_recursion.rs:35:5
   |
LL | /     fn ne(&self, other: &Self) -> bool {
LL | |
LL | |         self != &Foo2::B // no error here
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:37:9
   |
LL |         self != &Foo2::B // no error here
   |         ^^^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:39:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |         self == &Foo2::B // no error here
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:41:9
   |
LL |         self == &Foo2::B // no error here
   |         ^^^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:51:5
   |
LL | /     fn ne(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         self.ne(other)
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:54:9
   |
LL |         self.ne(other)
   |         ^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:56:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
...  |
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:60:9
   |
LL |         self.eq(other)
   |         ^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:102:5
   |
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:107:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         other == self
LL | |     }
   | |_____^
---
   |
LL |         other != other
   |         ^^^^^^^^^^^^^^
   |
   = note: `#[deny(clippy::eq_op)]` on by default

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:124:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         other == other
LL | |
LL | |     }
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:135:5
   |
LL | /     fn ne(&self, _other: &Self) -> bool {
LL | |
LL | |
LL | |         self != self
LL | |
LL | |     }
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:141:5
   |
LL | /     fn eq(&self, _other: &Self) -> bool {
LL | |
LL | |
LL | |         self == self
LL | |
LL | |     }
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:171:13
   |
LL | /             fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |                 self == other
LL | |             }
   | |_____________^
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:201:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         let mine = &self.field;
LL | |         let theirs = &other.field;
LL | |         mine == theirs
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:206:9
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:311:5
   |
LL | /     fn eq(&self, other: &Self) -> bool {
LL | |
LL | |
LL | |         let mine = &self.field;
LL | |         let theirs = &other.field;
LL | |         mine.eq(theirs)
LL | |     }
   | |_____^
   |
note: recursive call site
  --> tests/ui/unconditional_recursion.rs:316:9
   |
LL |         mine.eq(theirs)
   |         ^^^^^^^^^^^^^^^

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:383:5
   |
LL | /     fn from(f: BadFromTy1<'a>) -> Self {
LL | |
LL | |         f.into()
LL | |     }
   | |_____^
   |
---

error: function cannot return without recursing
##[error]  --> tests/ui/unconditional_recursion.rs:393:5
   |
LL | /     fn from(f: BadFromTy2<'a>) -> Self {
LL | |
LL | |         Into::into(f)
LL | |     }
   | |_____^
   |
---



FAILED TEST: tests/ui/checked_unwrap/simple_conditionals.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps" "--extern=clippy_config=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_config-f70fcb0bca23d4c7.rlib" "--extern=clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-8810885a8b0f7677.rlib" "--extern=clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-3b75e80d1d679bda.rlib" "--extern=futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-208855c7656dd2cf.rlib" "--extern=if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-d494e6b7c1a6e89b.rlib" "--extern=itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-22c8a3ae2ecf5885.rlib" "--extern=parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-ad691604c4582e99.rlib" "--extern=quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libquote-78ae6387337c7dd5.rlib" "--extern=regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libregex-75c78277780d7d9c.rlib" "--extern=serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libserde-4d5c3dc88b671e13.rlib" "--extern=serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libserde_derive-1d96f4727bf43663.so" "--extern=syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-24bc526a2407e76e.rlib" "--extern=tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-e3cdfdef09766281.rlib" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/release/deps" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/ui_test/0/tests/ui/checked_unwrap" "tests/ui/checked_unwrap/simple_conditionals.rs" "--edition" "2021"

error: actual output differed from expected
Execute `cargo uibless` to update `tests/ui/checked_unwrap/simple_conditionals.stderr` to the actual output
--- tests/ui/checked_unwrap/simple_conditionals.stderr
+++ <stderr output>
---

error: called `unwrap` on `x` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:47:9
   |
LL |     if x.is_some() {
   |     -------------- help: try: `if let Some(<item>) = x`
LL |         // unnecessary
LL |         x.unwrap();
   |         ^^^^^^^^^^
   |
note: the lint level is defined here
  --> tests/ui/checked_unwrap/simple_conditionals.rs:2:35
   |
LL | #![deny(clippy::panicking_unwrap, clippy::unnecessary_unwrap)]
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: called `expect` on `x` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:51:9
   |
LL |     if x.is_some() {
   |     -------------- help: try: `if let Some(<item>) = x`
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:55:9
   |
---
   |
LL |     if x.is_some() {
   |        ----------- because of this check
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:64:9
   |
---

error: called `unwrap` on `x` after checking its variant with `is_none`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:68:9
   |
LL |     if x.is_none() {
   |     -------------- help: try: `if let Some(<item>) = x`
...
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: called `unwrap` on `x` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:13:13
   |
LL |         if $a.is_some() {
   |         --------------- help: try: `if let Some(<item>) = x`
LL |             // unnecessary
LL |             $a.unwrap();
   |             ^^^^^^^^^^^
...
LL |     m!(x);
   |     ----- in this macro invocation
   |
   = note: this error originates in the macro `m` (in Nightly builds, run with -Z macro-backtrace for more info)

error: called `unwrap` on `x` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:81:9
   |
LL |     if x.is_ok() {
   |     ------------ help: try: `if let Ok(<item>) = x`
LL |         // unnecessary
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: called `expect` on `x` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:85:9
   |
LL |     if x.is_ok() {
   |     ------------ help: try: `if let Ok(<item>) = x`
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap_err()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:89:9
   |
LL |     if x.is_ok() {
   |        --------- because of this check
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:93:9
   |
LL |     if x.is_ok() {
   |        --------- because of this check
...
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: this call to `expect()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:97:9
   |
LL |     if x.is_ok() {
   |        --------- because of this check
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: called `unwrap_err` on `x` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:101:9
   |
LL |     if x.is_ok() {
   |     ------------ help: try: `if let Err(<item>) = x`
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:106:9
   |
LL |     if x.is_err() {
   |        ---------- because of this check
LL |         // will panic
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: called `unwrap_err` on `x` after checking its variant with `is_err`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:110:9
   |
LL |     if x.is_err() {
   |     ------------- help: try: `if let Err(<item>) = x`
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: called `unwrap` on `x` after checking its variant with `is_err`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:114:9
   |
LL |     if x.is_err() {
   |     ------------- help: try: `if let Ok(<item>) = x`
...
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: this call to `unwrap_err()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:118:9
   |
LL |     if x.is_err() {
   |        ---------- because of this check
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: called `unwrap` on `option` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:143:9
   |
LL |     if option.is_some() {
   |     ------------------- help: try: `if let Some(<item>) = &option`
LL |         option.as_ref().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:146:9
   |
---

error: called `unwrap` on `result` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:153:9
   |
LL |     if result.is_ok() {
   |     ----------------- help: try: `if let Ok(<item>) = &result`
LL |         result.as_ref().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:156:9
   |
LL |     if result.is_ok() {
   |        -------------- because of this check
...
LL |         result.as_ref().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: called `unwrap` on `option` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:162:9
   |
LL |     if option.is_some() {
   |     ------------------- help: try: `if let Some(<item>) = &mut option`
LL |         option.as_mut().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:165:9
   |
---

error: called `unwrap` on `result` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:171:9
   |
LL |     if result.is_ok() {
   |     ----------------- help: try: `if let Ok(<item>) = &mut result`
LL |         result.as_mut().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:174:9
   |
LL |     if result.is_ok() {
   |        -------------- because of this check
...
LL |         result.as_mut().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

---

error: called `unwrap` on `x` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:47:9
   |
LL |     if x.is_some() {
   |     -------------- help: try: `if let Some(<item>) = x`
LL |         // unnecessary
LL |         x.unwrap();
   |         ^^^^^^^^^^
   |
note: the lint level is defined here
  --> tests/ui/checked_unwrap/simple_conditionals.rs:2:35
   |
LL | #![deny(clippy::panicking_unwrap, clippy::unnecessary_unwrap)]
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: called `expect` on `x` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:51:9
   |
LL |     if x.is_some() {
   |     -------------- help: try: `if let Some(<item>) = x`
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:55:9
   |
---
   |
LL |     if x.is_some() {
   |        ----------- because of this check
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:64:9
   |
---

error: called `unwrap` on `x` after checking its variant with `is_none`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:68:9
   |
LL |     if x.is_none() {
   |     -------------- help: try: `if let Some(<item>) = x`
...
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: called `unwrap` on `x` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:13:13
   |
LL |         if $a.is_some() {
   |         --------------- help: try: `if let Some(<item>) = x`
LL |             // unnecessary
LL |             $a.unwrap();
   |             ^^^^^^^^^^^
...
LL |     m!(x);
   |     ----- in this macro invocation
   |
   = note: this error originates in the macro `m` (in Nightly builds, run with -Z macro-backtrace for more info)

error: called `unwrap` on `x` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:81:9
   |
LL |     if x.is_ok() {
   |     ------------ help: try: `if let Ok(<item>) = x`
LL |         // unnecessary
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: called `expect` on `x` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:85:9
   |
LL |     if x.is_ok() {
   |     ------------ help: try: `if let Ok(<item>) = x`
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap_err()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:89:9
   |
LL |     if x.is_ok() {
   |        --------- because of this check
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:93:9
   |
LL |     if x.is_ok() {
   |        --------- because of this check
...
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: this call to `expect()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:97:9
   |
LL |     if x.is_ok() {
   |        --------- because of this check
...
LL |         x.expect("an error message");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: called `unwrap_err` on `x` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:101:9
   |
LL |     if x.is_ok() {
   |     ------------ help: try: `if let Err(<item>) = x`
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:106:9
   |
LL |     if x.is_err() {
   |        ---------- because of this check
LL |         // will panic
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: called `unwrap_err` on `x` after checking its variant with `is_err`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:110:9
   |
LL |     if x.is_err() {
   |     ------------- help: try: `if let Err(<item>) = x`
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: called `unwrap` on `x` after checking its variant with `is_err`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:114:9
   |
LL |     if x.is_err() {
   |     ------------- help: try: `if let Ok(<item>) = x`
...
LL |         x.unwrap();
   |         ^^^^^^^^^^

error: this call to `unwrap_err()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:118:9
   |
LL |     if x.is_err() {
   |        ---------- because of this check
...
LL |         x.unwrap_err();
   |         ^^^^^^^^^^^^^^

error: called `unwrap` on `option` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:143:9
   |
LL |     if option.is_some() {
   |     ------------------- help: try: `if let Some(<item>) = &option`
LL |         option.as_ref().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:146:9
   |
---

error: called `unwrap` on `result` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:153:9
   |
LL |     if result.is_ok() {
   |     ----------------- help: try: `if let Ok(<item>) = &result`
LL |         result.as_ref().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:156:9
   |
LL |     if result.is_ok() {
   |        -------------- because of this check
...
LL |         result.as_ref().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: called `unwrap` on `option` after checking its variant with `is_some`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:162:9
   |
LL |     if option.is_some() {
   |     ------------------- help: try: `if let Some(<item>) = &mut option`
LL |         option.as_mut().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:165:9
   |
---

error: called `unwrap` on `result` after checking its variant with `is_ok`
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:171:9
   |
LL |     if result.is_ok() {
   |     ----------------- help: try: `if let Ok(<item>) = &mut result`
LL |         result.as_mut().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: this call to `unwrap()` will always panic
##[error]  --> tests/ui/checked_unwrap/simple_conditionals.rs:174:9
   |
LL |     if result.is_ok() {
   |        -------------- because of this check
...
LL |         result.as_mut().unwrap();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

---



FAILED TEST: tests/ui/crashes/ice-9463.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps" "--extern=clippy_config=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_config-f70fcb0bca23d4c7.rlib" "--extern=clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-8810885a8b0f7677.rlib" "--extern=clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-3b75e80d1d679bda.rlib" "--extern=futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-208855c7656dd2cf.rlib" "--extern=if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-d494e6b7c1a6e89b.rlib" "--extern=itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-22c8a3ae2ecf5885.rlib" "--extern=parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-ad691604c4582e99.rlib" "--extern=quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libquote-78ae6387337c7dd5.rlib" "--extern=regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libregex-75c78277780d7d9c.rlib" "--extern=serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libserde-4d5c3dc88b671e13.rlib" "--extern=serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libserde_derive-1d96f4727bf43663.so" "--extern=syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-24bc526a2407e76e.rlib" "--extern=tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-e3cdfdef09766281.rlib" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/release/deps" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/ui_test/0/tests/ui/crashes" "tests/ui/crashes/ice-9463.rs" "--edition" "2021"

error: actual output differed from expected
Execute `cargo uibless` to update `tests/ui/crashes/ice-9463.stderr` to the actual output
--- tests/ui/crashes/ice-9463.stderr
+++ <stderr output>
+error: literal out of range for `u32`
+  --> tests/ui/crashes/ice-9463.rs:5:22
+   |
+LL |     let _y = 1u32 >> 10000000000000u32;
+   |                      ^^^^^^^^^^^^^^^^^
+   |
+   = note: the literal `10000000000000u32` does not fit into the type `u32` whose range is `0..=4294967295`
+   = note: `#[deny(overflowing_literals)]` on by default
+
 error: this arithmetic operation will overflow
   --> tests/ui/crashes/ice-9463.rs:3:14
... 14 lines skipped ...
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to shift right by `1316134912_u32`, which would overflow
 
-error: literal out of range for `u32`
-  --> tests/ui/crashes/ice-9463.rs:5:22
-   |
-LL |     let _y = 1u32 >> 10000000000000u32;
-   |                      ^^^^^^^^^^^^^^^^^
-   |
-   = note: the literal `10000000000000u32` does not fit into the type `u32` whose range is `0..=4294967295`
-   = note: `#[deny(overflowing_literals)]` on by default
-
 error: aborting due to 3 previous errors
 

Full unnormalized output:
error: literal out of range for `u32`
##[error]  --> tests/ui/crashes/ice-9463.rs:5:22
   |
LL |     let _y = 1u32 >> 10000000000000u32;
   |                      ^^^^^^^^^^^^^^^^^
   |
   = note: the literal `10000000000000u32` does not fit into the type `u32` whose range is `0..=4294967295`
   = note: `#[deny(overflowing_literals)]` on by default

error: this arithmetic operation will overflow
##[error]  --> tests/ui/crashes/ice-9463.rs:3:14
   |
LL |     let _x = -1_i32 >> -1;
   |              ^^^^^^^^^^^^ attempt to shift right by `-1_i32`, which would overflow
   |
note: the lint level is defined here
  --> tests/ui/crashes/ice-9463.rs:1:9
   |
LL | #![deny(arithmetic_overflow)]
   |         ^^^^^^^^^^^^^^^^^^^

error: this arithmetic operation will overflow
##[error]  --> tests/ui/crashes/ice-9463.rs:5:14
   |
LL |     let _y = 1u32 >> 10000000000000u32;
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to shift right by `1316134912_u32`, which would overflow

error: aborting due to 3 previous errors



full stderr:
error: literal out of range for `u32`
##[error]  --> tests/ui/crashes/ice-9463.rs:5:22
   |
LL |     let _y = 1u32 >> 10000000000000u32;
   |                      ^^^^^^^^^^^^^^^^^
   |
   = note: the literal `10000000000000u32` does not fit into the type `u32` whose range is `0..=4294967295`
   = note: `#[deny(overflowing_literals)]` on by default

error: this arithmetic operation will overflow
##[error]  --> tests/ui/crashes/ice-9463.rs:3:14
   |
LL |     let _x = -1_i32 >> -1;
   |              ^^^^^^^^^^^^ attempt to shift right by `-1_i32`, which would overflow
   |
note: the lint level is defined here
  --> tests/ui/crashes/ice-9463.rs:1:9
   |
LL | #![deny(arithmetic_overflow)]
   |         ^^^^^^^^^^^^^^^^^^^

error: this arithmetic operation will overflow
##[error]  --> tests/ui/crashes/ice-9463.rs:5:14
   |
LL |     let _y = 1u32 >> 10000000000000u32;
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to shift right by `1316134912_u32`, which would overflow

error: aborting due to 3 previous errors


full stdout:

@bors
Copy link
Collaborator

bors commented Mar 31, 2025

☀️ Try build successful - checks-actions
Build commit: d15cb3d (d15cb3d099e66fae71f7e2c5c2e8b6d6390cddb0)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d15cb3d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
3.0% [0.2%, 30.8%] 278
Regressions ❌
(secondary)
5.3% [0.4%, 30.5%] 244
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.5%, -0.4%] 3
All ❌✅ (primary) 3.0% [0.2%, 30.8%] 278

Max RSS (memory usage)

Results (primary 24.1%, secondary 23.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
24.1% [7.5%, 53.6%] 290
Regressions ❌
(secondary)
23.2% [2.6%, 50.1%] 261
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 24.1% [7.5%, 53.6%] 290

Cycles

Results (primary 36.8%, secondary 27.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
36.8% [1.7%, 174.4%] 285
Regressions ❌
(secondary)
27.1% [1.3%, 88.5%] 255
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 36.8% [1.7%, 174.4%] 285

Binary size

Results (primary -0.0%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
-0.0% [-0.0%, -0.0%] 1
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.0%] 2
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 1

Bootstrap: 776.873s -> 735.956s (-5.27%)
Artifact size: 365.88 MiB -> 366.71 MiB (0.23%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 31, 2025
@SparrowLii
Copy link
Member Author

The wall-time results looks good, and without compilation failures. Close it now.

@SparrowLii SparrowLii closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants