Add 32-bit ARM support (armeabi and armeabi-v7a)
#199
Conversation
There was a problem hiding this comment.
Thanks! If you don't mind I'll first merge some other PRs that fix clippy lints and simplify the implementation for these enums. After that, we can rebase this and take a closer look.
Perhaps some CI tests for this architecture are useful, see how we do it for the other targets.
| match self.getkey(device, "CPUArchitecture")?.as_str() { | ||
| "arm64" | "arm64e" => Ok(Arch::Arm64), | ||
| "armv7" => Ok(Arch::Armv7), | ||
| "arm" => Ok(Arch::Arm), | ||
| "x86_64" => Ok(Arch::X64), |
There was a problem hiding this comment.
This is iOS code, did you confirm that it returns x86_64?
There was a problem hiding this comment.
I honestly didn't know what this does in first place
| #[repr(u8)] | ||
| pub enum Target { | ||
| ArmV7a = 1, | ||
| Arm64V8a = 2, | ||
| X86 = 3, | ||
| X86_64 = 4, | ||
| Armeabi = 2, | ||
| Arm64V8a = 3, | ||
| X86 = 4, | ||
| X86_64 = 5, |
There was a problem hiding this comment.
Changing the repr values here might not be desired, but I need to check where it is even used.
MarijnS95
changed the title
armeabi and armeabi-v7a support
MarijnS95
changed the title
armeabi and armeabi-v7a supportarmeabi and armeabi-v7a)
Sure, no problem. will add it. |
|
Looks like both tests are failing, so it's definitely good that we have them to catch things early as that means more work is required before this is ready. |
Yes, some package trowed an error in some type mismatch, and armv7 had unsupported sdk version, how do I change it btw, and in macos one failed for missing lld linker. I noticed there's almost no doc for the tool yet, I think I can work on that too. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
When I mentioned "If you don't mind I'll first merge some other PRs that fix clippy lints" above, I meant #198 which will fix these issues. There's still one more problem to go, after which you can rebase on top and the CI should only focus on the resulting changes from adding 32-bit ARM support. |
|
@monzeromer-hub / @monzeromer-lab the relevant CI fixes have been merged, you can rebase now. |
Closes #195
I think now builds for 32-bit ARMv7 Android (armeabi-v7a) is possible, I tested it manually, so yes, testing is missing still. Use
x build --platform android --arch armv7for armv7 or--arch armwhich will use androideabi.This is my first ever contribution, So yes, I don't know what I'm doing.
let me know what I'm doing wrong so I can make sure everything is good to go.