Remove static mut
in chgrp tests and fix memleak inside get_groups
#386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc and rust-analyzer issues a warning on the use of
static mut
globals hence the change to aRwLock
.The memory leak was from
libc::malloc
not being accompanied by a correspondinglibc::free
. There are multiple exit points (from thepanic
s) so it's simpler to just RAII it with aVec
.