refactor: remove V2 and obsolete references #994
Conversation
smol-ninja
changed the title
andreivladbrg
force-pushed
the
staging
branch
3 times, most recently
from
96e3209
to
a97e5ae
Compare
refactor: refer to Lockup contracts Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
smol-ninja
force-pushed
the
refactor/remove-v2
branch
from
d7dc3e2
to
2be3704
Compare
smol-ninja
changed the title
smol-ninja
force-pushed
the
refactor/remove-v2
branch
from
4a72552
to
be15eed
Compare
There was a problem hiding this comment.
Great work!
I see that there are multiple references , especially.MD files, that point to v2-core. Since we will most likely coordinate the merge of staging to main and the renaming of the repo to lockup, I think it's safe to change them now, wdyt?
For example:
Line 89 in a34e528
Feedback below, which I will create a PR with the some of the fixes:
| @@ -9,7 +9,7 @@ Parameters | |||
|
|
|||
| Licensor: Sablier Labs Ltd | |||
|
|
|||
| Licensed Work: Sablier V2 Core The Licensed Work is (C) 2024 Sablier Labs Ltd | |||
| Licensed Work: Sablier Lockup The Licensed Work is (C) 2024 Sablier Labs Ltd | |||
|
|
|||
| Additional Use Grant: Any uses listed and defined at v2-core-license-grants.sablier.eth | |||
There was a problem hiding this comment.
@PaulRBerg should we take the ens domain for lockup-license-grants.sablier.eth ?
There was a problem hiding this comment.
Yes, we should.
For anything that requires submitting a multisig transaction, you can tag @maxdesalle. He initiates the multisig txs — I just execute them.
style: center headers style: improve the asci art style: remove empty spaces chore: add todos
Addresses my feedback on 994
refactor: use package versions in NFTDescriptor_Fork_Test
Yes, I was keeping them until we rename the repo but it does not matter. So, I've changed them in 5ad4481. |
|
Added a new commit: 11cd564. LMK if it all looks good now @andreivladbrg. PS: there are a few open conversations pending your reply. |
Co-authored-by: Andrei Vlad Birgaoanu <[email protected]> * refactor: remove V2 from codebase refactor: refer to Lockup contracts * fix: make NFTDescriptor compatible with previous versions * fix: use sablier as variabel name in tokenURI * chore: update precompiles * refactor: prefix Sablier in NFT mapsymbol * refactor(periphery): order alphabetically functions in batch interfaces style: center headers style: improve the asci art style: remove empty spaces chore: add todos * test: computing merkle proof for 1 leaf * refactor: use lockup as variable in NFT Descriptor * refactor: replace v2-core with lockup in urls * test: add v1.2.0 to NFTDescriptor_Fork_Test refactor: use package versions in NFTDescriptor_Fork_Test * refactor: rename SablierNFTDescriptor to LockupNFTDescriptor * docs(README): remove periphery reference * test: add TODO over loadDependencies function --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]> Co-authored-by: andreivladbrg <[email protected]>
Co-authored-by: Andrei Vlad Birgaoanu <[email protected]> * refactor: remove V2 from codebase refactor: refer to Lockup contracts * fix: make NFTDescriptor compatible with previous versions * fix: use sablier as variabel name in tokenURI * chore: update precompiles * refactor: prefix Sablier in NFT mapsymbol * refactor(periphery): order alphabetically functions in batch interfaces style: center headers style: improve the asci art style: remove empty spaces chore: add todos * test: computing merkle proof for 1 leaf * refactor: use lockup as variable in NFT Descriptor * refactor: replace v2-core with lockup in urls * test: add v1.2.0 to NFTDescriptor_Fork_Test refactor: use package versions in NFTDescriptor_Fork_Test * refactor: rename SablierNFTDescriptor to LockupNFTDescriptor * docs(README): remove periphery reference * test: add TODO over loadDependencies function --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]> Co-authored-by: andreivladbrg <[email protected]>
This PR closes 2nd and 3rd points of Package tethering.
Changelog