Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3007.x] fix sync_renderers failure when the custom renderer is specified via config #66454

Open
wants to merge 5 commits into
base: 3007.x
Choose a base branch
from
Open

[3007.x] fix sync_renderers failure when the custom renderer is specified via config #66454

wants to merge 5 commits into from

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes #66453

Previous Behavior

exception is raised when renderer in pipe fails to be found

New Behavior

renderer falls back to default if any renderer in pipe fails to be found

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner April 29, 2024 23:52
@nicholasmhughes nicholasmhughes requested review from twangboy and removed request for a team April 29, 2024 23:52
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title fix sync_renderers failure when the custom renderer is specified via config [master] fix sync_renderers failure when the custom renderer is specified via config Apr 29, 2024
@nicholasmhughes nicholasmhughes changed the base branch from master to 3007.x April 29, 2024 23:52
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] fix sync_renderers failure when the custom renderer is specified via config [3007.x] fix sync_renderers failure when the custom renderer is specified via config Apr 29, 2024
twangboy
twangboy previously approved these changes May 13, 2024
View reviewed changes
@dwoz dwoz requested a review from a team as a code owner October 21, 2024 21:23
dmurphy18
dmurphy18 requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to ensure ran pre-commit install to ensure you have cleaned up pre-commit errors before running the PR builds etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

@dmurphy18 dmurphy18 Awaiting requested review from dmurphy18

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] sync_renderers fails when the custom renderer is specified via config
4 participants
@nicholasmhughes @twangboy @dmurphy18 @dwoz