Improve ZeroMQ ReqServer load-balancing #67215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salt currently uses a Broker socket to distribute incoming requests to MWorkers using a round-robin discipline, which doesn't take into account if the worker is already busy and will not be able to serve the request in a timely manner. This patch is based on the recommended ZMQ [load-balancing pattern](https://zguide.zeromq.org/docs/chapter3/#A-Load-Balancing-Message-Broker), which flips it to a Router socket that idle MWorkers will pull from. This resolves the SaltReqTimeout issues in testing and gets us better visibility into the utilization of workers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salt currently uses a Broker socket to distribute incoming requests to MWorkers using a round-robin discipline, which doesn't take into account if the worker is already busy and will not be able to serve the request in a timely manner. This patch is based on the recommended ZMQ load-balancing pattern, which flips it to a Router socket that idle MWorkers will pull from. This resolves the SaltReqTimeout issues in testing and gets us better visibility into the utilization of workers.
What does this PR do?
What issues does this PR fix or reference?
Fixes
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.