Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Convert Footer to Navigation for Enhanced Navigation #14

Closed
samucodesh opened this issue Feb 4, 2025 · 0 comments · Fixed by #15
Closed

Refactor: Convert Footer to Navigation for Enhanced Navigation #14

samucodesh opened this issue Feb 4, 2025 · 0 comments · Fixed by #15
Assignees
@samucodesh
Labels
enhancement New feature or request

Comments

@samucodesh
Copy link
Owner

Description:

This issue involves refactoring the website's footer to utilize a <nav> element instead. The goal is to improve the navigation experience

Why is this change necessary?

  • Improved Navigation Experience: This change allows us to structurally and stylistically enhance the way users interact with links.
  • External links have target="_blank" attribute for proper behavior.
  • CSS styles are adjusted or created to ensure proper touch target size and spacing for navigation links, especially on mobile devices.
@samucodesh samucodesh added the enhancement New feature or request label Feb 4, 2025
@samucodesh samucodesh self-assigned this Feb 4, 2025
samucodesh added a commit that referenced this issue Feb 4, 2025
@samucodesh
refactor(css): Update navigation styles and remove footer styles
ebcfb2f 
Updates CSS for the navigation after converting the footer to a nav element.

Removes old footer styles and implements styles for better touch target size and spacing, particularly on mobile.

[Closes #14](#14)

Signed-off-by: Samuel Soto <[email protected]>
@samucodesh samucodesh mentioned this issue Feb 4, 2025
Merged
samucodesh added a commit that referenced this issue Feb 4, 2025
@samucodesh
refactor: Refactor Footer to Navigation Element for Enhanced Navigati…
73f5d53 
…on (#15)

## Description

This pull request addresses [issue
#14](#14),
which involves refactoring the website's footer to use a `<nav>`
element. This change is made to improve the overall navigation
experience and accessibility, while enhancing the structural semantic of
the HTML. The specific goals are to provide more intuitive links with
the website's navigation structure.

### Key Changes:

* **HTML Refactoring:** Replaced the `<footer>` element with a `<nav>`
element, semantically structuring the navigation links.
* **Added Target Attributes:** External links now have `target="_blank"`
for proper behavior, opening in new tabs.
* **CSS Styling:** Footer CSS styles have been removed, updated
navigation styles have been added, and the styles are adjusted to ensure
appropriate touch target sizes and spacing for navigation links,
especially on mobile devices.

## Related Tickets & Documents

Closes #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samucodesh samucodesh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@samucodesh