refactor: Refactor Footer to Navigation Element for Enhanced Navigation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the footer to use a <nav> element for improved semantic HTML. Adds target=_blank to external links, opening them in new tabs. [Closes #14](#14) Signed-off-by: Samuel Soto <[email protected]>
Updates CSS for the navigation after converting the footer to a nav element. Removes old footer styles and implements styles for better touch target size and spacing, particularly on mobile. [Closes #14](#14) Signed-off-by: Samuel Soto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issue #14, which involves refactoring the website's footer to use a
<nav>element. This change is made to improve the overall navigation experience and accessibility, while enhancing the structural semantic of the HTML. The specific goals are to provide more intuitive links with the website's navigation structure.Key Changes:
<footer>element with a<nav>element, semantically structuring the navigation links.target="_blank"for proper behavior, opening in new tabs.Related Tickets & Documents
Closes #14