Add onUpdate callback

[michellocana]

• onUpdate prop added on AutoTextSize React component
• onUpdate option added on autoTextSize vanilla method
• yalc added on devDependencies
• Fix errors while trying to run the example project

Screencast.from.30-11-2023.17.22.12.webm

[ViktorQvarfordt]

Thank you! Just one question: Is there a risk that adding onUpdate to the dependency array will re-trigger the useEffect very often since we don't pass stable references for the onUpdate function? I.e., useCallback might be needed.

[michellocana]

Thank you! Just one question: Is there a risk that adding onUpdate to the dependency array will re-trigger the useEffect very often since we don't pass stable references for the onUpdate function? I.e., useCallback might be needed.

Good catch, we should probably wrap this callback in a ref, so we always get the latest value without impacting useEffect calls

[michellocana]

@ViktorQvarfordt done!

[ViktorQvarfordt]

This usage feels a bit magic. Perhaps we should move the responsibility of memorizing the onUpdate function to the user of the hook instead? I mean they'd pass useCallback(f, []) instead of f

[michellocana]

i'm okay with letting the user wrap the callback on an useCallback, i just used a ref to keep the callback updated because a lot of people don't have the habit to use it, but maybe we can just add a warning in the README and pass this responsibility to the user

[ViktorQvarfordt]

I see, perhaps your approach would be good. I'm not familiar with the use of useImperativeHandle in this way. I would have expected:

const onUpdateRef = useRef()

useEffect(() => {
  onUpdateRef.current = onUpdateRef
}, [onUpdateRef])

[michellocana]

yeah, both the useEffect and useImperativeHandle approaches do the same in this case, but I can change to useEffect if you want, no problem

[michellocana]

hey @ViktorQvarfordt, sorry for the huge delay, I've just updated the branch with the origin one, let me know if you still want me to change the useImperativeHandle call.

[ViktorQvarfordt]

Yeah, most people aren't familiar with this hook. Simple is good!

[michellocana]

done!