Template: reuse LazyResponse for rendered response #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Leaving this as draft because I haven't written tests and update the doc for this.) |
Previously, only status, headers, and content type are passed to the final rendered response. After this change, the LazyResponse is preserved and only has its body changed after rendering. This allows for, e.g., setting cookie for the LazyResponse.
Huy-Ngo
force-pushed
the
templating-preserve-response
branch
from
fd9513a
to
4bad4f0
Compare
|
Fixed up the tests. I see OAS tests failing, but that's not related. I want to add a test with cookies but Not sure where to write doc though. |
ahopkins
reviewed
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only status, headers, and content type are passed to the final rendered response. After this change, the LazyResponse is preserved and only has its body changed after rendering. This allows for, e.g., setting cookie for the LazyResponse.