Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging extraction to background logger #252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahopkins
Copy link
Member

Extracts logging config to pass to the background logger

Comment on lines +3 to +9
from typing import Any, Dict, Optional, TypedDict


class LoggerConfig(TypedDict):
level: str
propagate: bool
handlers: list[str]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from typing import Any, Dict, Optional, TypedDict
class LoggerConfig(TypedDict):
level: str
propagate: bool
handlers: list[str]
from typing import Any, Dict, List, Optional, TypedDict
class LoggerConfig(TypedDict):
level: str
propagate: bool
handlers: List[str]

Simple fix for the CI failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants