This repository was archived by the owner on Oct 12, 2020. It is now read-only.
Small bugfixes and manifest_version 2.0 compatiblity #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest.json had to be modified because some options were obsolete. A background page is autogenerated now so no need to have it. Inline eventhandlers are no longer supported by default so they are initialized in js instead.
… some corner cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a typo and a bug in desktop notifications that was caused by a bug in Chrome.
Also, I fixed the manifest version to 2.0 and made relevant changes. The background page is now autogenerated and inline javascript calls in HTML have been converted to event handlers.
sanitz: I'd really appreciate it if you took the time to update the version of the plugin found in Chrome Store.