fix(toUTF8): replace deprecated unescape with decodedURIComponent #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! The changes in this PR are giving wrong md5 results unfortunately. :/ |
Hey! I’ll take a look at this again :) I thought decodeURIComponent had the correct encodings to begin with, and that’s why I updated the tests. |
|
Hey @satazor I just pushed up some changes. Specifically, I reimplemented the native unescape from V8. I noticed there were a few functions responsible for converting characters to hex in the codebase. However, I wasn't sure which one would accomplish what I needed, so I ported the hexing function from V8. Let me know your thoughts 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the toUTF8 function to use decodedURIComponent, instead of the deprecated unescape as suggested here MDN.