Make CellsByIdentities into S3 generic #202
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Seurat Team,
This PR is definitely something optional and totally fine if rejected. Recently, I have been updating scCustomize to work with new version of liger which has substantial improvements. It's been wonderful that SeuratObject has so many data access functions as S3 generics (
Cells
,Features
,WhichCells
, etc) because I can easily reexport them and extend them to function with liger objects in seamless manner so that same function works with both Seurat and liger objects.One function, that I recently wrote version for liger, which would be great to have as generic is
CellsByIdentities
. I realize this doesn't fit use cases of most other generics in SeuratObject because it's only designed to work with full objects and Assay or other classes.For this PR:
CellsByIdentities
again following formats used for other generics.Again, totally realize this may either not be priority or not something that you want to change and that's all good and I can implement liger version with different function name if so.
Thanks!
Sam