Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do FindMarkers DE p-values vary significantly between V4 and V5? #9443

Open
mauritsunkel opened this issue Oct 31, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@mauritsunkel
Copy link

Hi,

In Seurat V5 news, it was stated that the DE pseudocount is changed, now performed at the group level rather than cell level (#8462). (Next to min.pct defaults having gone from 0.1 to 0.01 and logfc.threshold from 0.25 to 0.1)
There is no note about p-value calculation having changed at all.

In V5, especially very lowly expressed genes in either groups (pct.1 || pct.2 < 0.01) now have substantially higher log2FC, however, they also have substantially lower p-val(-adj). In V4, I would filter out a relevant portion of these lowly expressed genes based on having high p-value.

I would like to run the new V5 estimations for log2FC, yet keep the V4 calculation for p-values, as expected.
Could it be explained/noted why p-values are changed in V5 from V4 as well?

Best,
Maus

@mauritsunkel mauritsunkel added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant