fix documentation for adding field with default #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chdsbd
commented
Aug 25, 2022
| @@ -106,6 +106,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT uuid(); | |||
| let ok_sql = r#" | |||
| -- NON-VOLATILE | |||
| ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10; | |||
| ALTER TABLE "account" ADD COLUMN "last_modified" timestamptz DEFAULT now(); | |||
There was a problem hiding this comment.
our code for checking volatility of functions doesn't work. now() is stable, while a function like random is volatile.
select
proname,
pronamespace::regnamespace,
provolatile
from pg_proc
where proname = 'now'
or proname = 'random';I think we could hard code in a list of functions and then warn when we can't know for certain with a more detailed error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.