Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft: ZENKO-2968 enable sharding on bucket creation #1303

Open
wants to merge 1 commit into
base: development/8.1
Choose a base branch
from

Conversation

vrancurel
Copy link
Contributor

Enable sharding on bucket creation (experimental - open for comments)

@bert-e
Copy link
Contributor

bert-e commented Nov 18, 2020

Hello vrancurel,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 18, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @jonathan-gramain.

@vrancurel vrancurel force-pushed the feature/ZENKO-2968-enable-sharding branch from 58942d1 to 2230e76 Compare November 18, 2020 02:46
@vrancurel
Copy link
Contributor Author

This code is experimental, e.g. I assume if replicaset === undefined we want sharding, we probably want to propagate an explicit config param for enabling sharding.

@vrancurel
Copy link
Contributor Author

vrancurel commented Nov 18, 2020

Also we need to manage changestreams for the LogConsumer

@vrancurel vrancurel closed this Nov 18, 2020
@vrancurel vrancurel reopened this Nov 18, 2020
@vrancurel vrancurel force-pushed the feature/ZENKO-2968-enable-sharding branch from 2230e76 to c5f7163 Compare November 18, 2020 20:38
@vrancurel vrancurel force-pushed the feature/ZENKO-2968-enable-sharding branch 2 times, most recently from c5f7163 to 0cdee24 Compare November 18, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants