Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to view specific date range within Pomodoro history #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

finnigantime
Copy link

@finnigantime finnigantime commented Aug 2, 2020

This allows the history tab Pomodoro data to be filtered to a specific date range. This allows the user to, for example, visualize their Pomodoro history for just 2019.

  • Partially addresses More advanced statistics #75
  • I don't have much experience with Chrome extensions or Vue so not sure I did things correctly. I went off existing patterns I saw in the codebase. Feel free to call out anything weird.
  • The timestamp calculation on the beginning/end dates may be slightly off - I wasn't rigorous about zeroing out hh:mm:ss to the start of the day or dealing with timezones. But other than that it should work and most of the time you'd care to view data over a longer multi-day range, and you can always choose a day earlier or later than the range to safely include all data.
  • I only added locale strings for English. Is that okay?

before:

Screen Shot 2020-08-01 at 8 54 02 PM

after:

Screen Shot 2020-08-01 at 8 45 33 PM

Screen Shot 2020-08-01 at 8 45 48 PM

Screen Shot 2020-08-01 at 8 46 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant