feature: findings-manager-jira refactoring and ticket autoclose support #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mlflr
commented
Sep 19, 2024
•
mlflr
commented
- refactoring of the findings-manager-jira lambda code
- adds support of autoclosing of Jira tickets when Security Hub finding is resolved
- when autoclosing is enabled also events that are resolved are pushed towards step function. Resolved findings do not go to the events lambda. Step function then pushes findings with status RESOLVED towards the Jira lambda (only when they have a note with Jira ticket)
- fixes a bug in securityhub-findings-manager that always returns suppressed state when rules are processed successfully even if nothing was suppressed
Terraform Format and Style 🖌
|
files/step-function-artifacts/securityhub-findings-manager-orchestrator-graph.png
Outdated
Show resolved
Hide resolved
files/step-function-artifacts/securityhub-findings-manager-orchestrator.json.tpl
Show resolved
Hide resolved
marwinbaumannsbp
previously approved these changes
Oct 11, 2024
marwinbaumannsbp
previously approved these changes
Oct 14, 2024
…pting to transition
marwinbaumannsbp
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.