Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: CMK Fix #2

Merged
merged 19 commits into from
Jan 7, 2025
Merged

bug: CMK Fix #2

merged 19 commits into from
Jan 7, 2025

Conversation

Dennisvandermeulen
Copy link
Contributor

  • Fix to use the versionless ID when using CMK
  • Fix assignment of possible ID's to identity block
  • Add ID used in CMK block to list of identities: as mentioned in docs: The managed identity used in encryption also needs to be part of the identity block under identity_ids

@github-actions github-actions bot added the bug Something isn't working label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Terraform Format and Style 🖌success

Terraform Initialization ⚙️``

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


@Dennisvandermeulen
Copy link
Contributor Author

tested with an without CMK block defined, so no impact on existing deployment

Copy link
Contributor

@Blankf Blankf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, versionless!
lgmt

@Dennisvandermeulen Dennisvandermeulen merged commit c6c3980 into main Jan 7, 2025
5 of 7 checks passed
@Dennisvandermeulen Dennisvandermeulen deleted the cmk-fix branch January 7, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants