fix: use old license text #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before moving to scikit-build-core, this was the contents of the `License` field. Putting the entire contents of the license file here breaks `importlib.metadata.metadata`, and isn't needed - the license file is stored in the wheel already, and the currently only canonical location for license metadata is the trove classifiers. PEP 639, which is currently provisionally accepted and waiting support in packaging, PyPI, etc, solves this by supporting SPDX license expressions. But that's not ready yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before moving to scikit-build-core, this was the contents of the
Licensefield. Putting the entire contents of the license file here breaksimportlib.metadata.metadata("iminuit")(see python/cpython#119650), and isn't needed - the license file is stored in the wheel already, and the currently only canonical location for license metadata is the trove classifiers. PEP 639, which is currently provisionally accepted and waiting support in packaging, PyPI, etc, solves this by supporting SPDX license expressions. But that's not ready yet.(This is not critical, but a minor annoyance I hit while debugging)