Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qt widget sizing issues and simplify code #1075

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

HDembinski
Copy link
Member

@HDembinski HDembinski commented Feb 11, 2025

Closes #1074

The layout was changed so the parameters always take the minimal space. Font size was reduced to 11pt. The size of the result area was increased so that the full result can be seen on Windows.

The layout was not made user-adjustable, because parameters, buttons, and the result have fixed sizes anyway, so the only area with an adjustable size is the plot.

The code was simplified in a couple of places and some blocks refactored to functions to improve clarity.

Minimum and maximum values for each slider are taken from the Minuit.limits.

@HDembinski
Copy link
Member Author

@adryyan Can you test this code on your platform? Check whether the layout still looks good for you?

@adryyan
Copy link
Contributor

adryyan commented Feb 11, 2025

Yes, I quickly ran your example and the ones I still had locally and the layout still looks good on my platform. Thanks for the improvements.

@HDembinski HDembinski merged commit 686131e into develop Feb 19, 2025
9 checks passed
@HDembinski HDembinski deleted the fix_qtwidget branch February 19, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving the Qt Widget
2 participants