Ticket wrapper

[ckeshava]

This PR introduces wrapper for Ticket Ledger Object

High Level Overview of Change

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Tests (You added tests for code that already exists, or your new feature included in this PR)
• Documentation Updates
• Release

[scottschurr]

Nice job on this! But, since I'm picky, I found a couple of things I'd like to change.

Names are hard but important. I think

using Tickets = TicketImpl<true>;

is not a great name. Each ledger object represents only one Ticket. I prefer to take the approach that you took with one of your other pull requests. If we rename TicketImpl to TicketLedgerObjImpl then other naming problems get much simpler. The new name is longer, but not outrageously so.

Other than that, I think the implementation for the TicketKeylet should be moved below the AcctRootKeylet in Keylet.h. That will make it easier to alphabetize the Keylets when all of these changes are merged.

Here is a commit that makes the suggested changes: https://github.com/scottschurr/rippled/commits/chenna-ticketWrapper. You can use that as an example or cherry-pick. Your call.

[ckeshava]

thank you Scott! I'll incorporate this commit.

Regarding alphabetizing the Keylets, I thought I could do it when I merge all the commits together. I'll keep it in mind for future commits, thanks.

[scottschurr]

You can alphabetize the Keylets during the merge. But if they are already alphabetized then that will make the merging easier.