-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add parser for JSON with JS comment #137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 87.78% 87.81% +0.02%
==========================================
Files 11 11
Lines 475 476 +1
Branches 103 103
==========================================
+ Hits 417 418 +1
Misses 52 52
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not forget setup.py
.
2aef0d4
to
5bb1a87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a least one test that covers a scenario that was not supported by the old code and now works thanks to your changes?
Can this library handle #53? Otherwise, it may make sense to look into using https://github.com/codecobblers/dirtyjson instead as suggested by @whalebot-helmsman at #126 (comment) |
After quick testing, both library can not handle #53. |
Let me know if I can help with the tests. |
yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kiollpt , looks great 👍
I encountered the issue of parsing
json-ld
with JS comments. Finally, I found thejstyleson
package that could solve.Reproduce issue: