Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename KeyMap -> Map, DequeStore -> Deque #74

Open
wants to merge 5 commits into
base: match-cw-storage-plus-base
Choose a base branch
from

Conversation

eshelB
Copy link
Contributor

@eshelB eshelB commented Feb 13, 2023

No description provided.

@eshelB eshelB added the match cw-storage-plus Issue aims to cause api to conform to cw-storage-plus' types label Feb 13, 2023
Copy link
Member

@toml01 toml01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change Keyset -> Set to match the new naming scheme?

@@ -14,9 +14,9 @@ The APIs remains the same, but it is necessary to upgrade the contract's `cosmwa
- This release changes the internal toolkit package to be part of the workspace - this fixes default-features flags in some of the crates. In addition, crates used by the toolkit have been bumped, and the edition of the toolkit crates has been bumped to 2021.

- Added the `Keyset` storage object (A hashset like storage object).
- Allowed further customisation of Keymap and Keyset with new constructor structs called `KeymapBuilder` and `KeysetBuilder` which allow the user to disable the iterator feature (saving gas) or adjust the internal indexes' page size so that the user may determine how many objects are to be stored/loaded together in the iterator.
- Allowed further customisation of Map and Keyset with new constructor structs called `MapBuilder` and `KeysetBuilder` which allow the user to disable the iterator feature (saving gas) or adjust the internal indexes' page size so that the user may determine how many objects are to be stored/loaded together in the iterator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a changelog, I guess it makes sense to keep it as it was and add a bullet specifying the name change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
match cw-storage-plus Issue aims to cause api to conform to cw-storage-plus' types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants