Provide trailer in a fallback language when the original TMDB request doesn't provide one in the chosen localization #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StancuFlorin
requested review from
sct,
TheCatLady,
danshilm and
OwsleyJr
as code owners
StancuFlorin
force-pushed
the
fix-en-trailer
branch
from
2a7c1c7 to
13292c9
Compare
|
@sct - Hi Ryan, can you please take a look on this PR? It is pretty short. |
…, for related videos of a movie or TV show
sct
approved these changes
Feb 26, 2025
|
Looks good @StancuFlorin. Thank you for this. I wasn't aware TMDB supported this parameter. Docs could use some work. |
|
@all-contributors please add @StancuFlorin for code |
|
I've put up a pull request to add @StancuFlorin! 🎉 |
|
🎉 This PR is included in version 1.34.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When localizing to a language other than English, the data retrieved from TMDb is also localized to that language. As a result, the
relatedVideosdata attached to a movie in Overseerr may lack the necessary information to display the "view trailer" button on the movie/TV show details page.Fortunately, the TMDb API supports multi-language requests, allowing you to fetch video data in multiple languages.
https://www.themoviedb.org/talk/6712613425c70b8b1d67ba57?page=1
I know that the request to TMDb includes
include_video_language=en, enwhen using English. However, I think that this is a small trade-off compared to adding an additional conditional check in the code.Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed