tests: relax test_file_system_space check for empty filesystems #2675
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When statvfs reports information about a mounted filesystem, it populates a structure with several fields including: - f_blocks: the total data blocks in the filesystem - f_bfree: the available free blocks On empty filesystems or those containing only empty files/directories, f_blocks and f_bfree can be identical since empty files and directories in Linux typically only consume inodes rather than data blocks. This was causing test failures on Linux systems with no non-empty files under "/tmp": ``` /home/kefu/dev/seastar/tests/unit/file_io_test.cc(962): fatal error: in "test_file_system_space": critical check si.free < si.capacity has failed [100030640128 >= 100030640128] ``` This change relaxes the test to accommodate filesystems where all blocks are free, preventing false failures when "/tmp" contains no actual file data. Signed-off-by: Kefu Chai <[email protected]>
|
@bhalevy hi Benny, could you please take a look at this change. i happened to run this test on my workstation right after it booted, and the test failed. hence this change. |
bhalevy
approved these changes
Mar 4, 2025
|
@scylladb/seastar-maint hello maintainers, could you help merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When statvfs reports information about a mounted filesystem, it populates a structure with several fields including:
On empty filesystems or those containing only empty files/directories, f_blocks and f_bfree can be identical since empty files and directories in Linux typically only consume inodes rather than data blocks.
This was causing test failures on Linux systems with no non-empty files under "/tmp":
This change relaxes the test to accommodate filesystems where all blocks are free, preventing false failures when "/tmp" contains no actual file data.