Skip to content

Commit

Permalink
Make TerminalId nullable
Browse files Browse the repository at this point in the history
  • Loading branch information
Sébastien Nikolaou committed Sep 2, 2024
1 parent 05b2d0a commit 948d562
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to `sebdesign/laravel-viva-payments` will be documented in t
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [6.1.2] - 2024-09-02

### Fixed

- Make `TerminalId` nullable

## [6.1.1] - 2024-07-05

### Added
Expand Down
4 changes: 2 additions & 2 deletions phpstan.neon.dist
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ parameters:

typeAliases:
RecurringTransactionArray: 'array{Emv:?string, Amount:float, StatusId:string, RedirectUrl:?string, CurrencyCode:string, TransactionId:string, TransactionTypeId:int, ReferenceNumber:int, IssuerMessage:?string, AuthorizationId:string, IssuerMessageControl:mixed, Ctap:mixed, RetrievalReferenceNumber:string, Loyalty:?string, CartesBancaires:?string, ThreeDSecureStatusId:int, ErrorCode:int, ErrorText:?string, TimeStamp:string, CorrelationId:?string, EventId:int, Success:bool, ServiceId?:string}'
TransactionFailedArray: 'array{Moto:bool, Email:string, Phone:?string, BankId:string, Systemic:bool, Switching:bool, ParentId:?string, Amount:float, ChannelId:string, TerminalId:int, MerchantId:string, OrderCode:string, ProductId:?string, StatusId:string, FullName:string, ResellerId:?string, InsDate:string, TotalFee:float, CardUniqueReference:?string, CardToken:string, CardNumber:string, TipAmount:float, SourceCode:string, SourceName:string, Latitude:?float, Longitude:?float, CompanyName:?String, TransactionId:string, CompanyTitle:?string, PanEntryMode:string, ReferenceNumber:int, ResponseCode:?string, CurrencyCode:string, OrderCulture:string, MerchantTrns:?string, CustomerTrns:string, IsManualRefund:bool, TargetPersonId:?string, TargetWalletId:?string, LoyaltyTriggered:bool, TransactionTypeId:int, TotalInstallments:int, CardCountryCode:?string, CardIssuingBank:?string, RedeemedAmount:int, ClearanceDate:?int, CurrentInstallment:?int, Tags:string[], BillId:?string, ResellerSourceCode:?string, ResellerSourceName:?string, ResellerCompanyName:?string, ResellerSourceAddress:?string, CardExpirationDate:string, RetrievalReferenceNumber:?string, AssignedMerchantUsers:string[], AssignedResellerUsers:string[], CardTypeId:int, DigitalWalletId:?int, ResponseEventId:?string, ElectronicCommerceIndicator:?string}'
TransactionPaymentCreatedArray: 'array{Moto:bool, Email:string, Phone:?string, BankId:string, Systemic:bool, Switching:bool, ParentId:?string, Amount:float, ChannelId:string, TerminalId:int, MerchantId:string, OrderCode:string, ProductId:?string, StatusId:string, FullName:string, ResellerId:?string, InsDate:string, TotalFee:float, CardUniqueReference:?string, CardToken:string, CardNumber:string, TipAmount:float, SourceCode:string, SourceName:string, Latitude:?float, Longitude:?float, CompanyName:?String, TransactionId:string, CompanyTitle:?string, PanEntryMode:string, ReferenceNumber:int, ResponseCode:?string, CurrencyCode:string, OrderCulture:string, MerchantTrns:?string, CustomerTrns:string, IsManualRefund:bool, TargetPersonId:?string, TargetWalletId:?string, LoyaltyTriggered:bool, TransactionTypeId:int, TotalInstallments:int, CardCountryCode:?string, CardIssuingBank:?string, RedeemedAmount:int, ClearanceDate:?int, CurrentInstallment:?int, Tags:string[], BillId:?string, ResellerSourceCode:?string, ResellerSourceName:?string, ResellerCompanyName:?string, ResellerSourceAddress:?string, CardExpirationDate:string, RetrievalReferenceNumber:?string, AssignedMerchantUsers:string[], AssignedResellerUsers:string[], CardTypeId:int, DigitalWalletId:?int, ResponseEventId:?string, ElectronicCommerceIndicator:?string, BinId:?string, Ucaf:?string, DualMessage:?string, AcquirerApproved:?string, AuthorizationId:?string, OrderServiceId:?string, ConnectedAccountId:?string, MerchantCategoryCode:?string, ServiceId:?string, ExternalTransactionId:?string, ApplicationIdentifierTerminal:?string, Descriptor:?string, ConversionRate:?float}'
TransactionFailedArray: 'array{Moto:bool, Email:string, Phone:?string, BankId:string, Systemic:bool, Switching:bool, ParentId:?string, Amount:float, ChannelId:string, TerminalId:?int, MerchantId:string, OrderCode:string, ProductId:?string, StatusId:string, FullName:string, ResellerId:?string, InsDate:string, TotalFee:float, CardUniqueReference:?string, CardToken:string, CardNumber:string, TipAmount:float, SourceCode:string, SourceName:string, Latitude:?float, Longitude:?float, CompanyName:?String, TransactionId:string, CompanyTitle:?string, PanEntryMode:string, ReferenceNumber:int, ResponseCode:?string, CurrencyCode:string, OrderCulture:string, MerchantTrns:?string, CustomerTrns:string, IsManualRefund:bool, TargetPersonId:?string, TargetWalletId:?string, LoyaltyTriggered:bool, TransactionTypeId:int, TotalInstallments:int, CardCountryCode:?string, CardIssuingBank:?string, RedeemedAmount:int, ClearanceDate:?int, CurrentInstallment:?int, Tags:string[], BillId:?string, ResellerSourceCode:?string, ResellerSourceName:?string, ResellerCompanyName:?string, ResellerSourceAddress:?string, CardExpirationDate:string, RetrievalReferenceNumber:?string, AssignedMerchantUsers:string[], AssignedResellerUsers:string[], CardTypeId:int, DigitalWalletId:?int, ResponseEventId:?string, ElectronicCommerceIndicator:?string}'
TransactionPaymentCreatedArray: 'array{Moto:bool, Email:string, Phone:?string, BankId:string, Systemic:bool, Switching:bool, ParentId:?string, Amount:float, ChannelId:string, TerminalId:?int, MerchantId:string, OrderCode:string, ProductId:?string, StatusId:string, FullName:string, ResellerId:?string, InsDate:string, TotalFee:float, CardUniqueReference:?string, CardToken:string, CardNumber:string, TipAmount:float, SourceCode:string, SourceName:string, Latitude:?float, Longitude:?float, CompanyName:?String, TransactionId:string, CompanyTitle:?string, PanEntryMode:string, ReferenceNumber:int, ResponseCode:?string, CurrencyCode:string, OrderCulture:string, MerchantTrns:?string, CustomerTrns:string, IsManualRefund:bool, TargetPersonId:?string, TargetWalletId:?string, LoyaltyTriggered:bool, TransactionTypeId:int, TotalInstallments:int, CardCountryCode:?string, CardIssuingBank:?string, RedeemedAmount:int, ClearanceDate:?int, CurrentInstallment:?int, Tags:string[], BillId:?string, ResellerSourceCode:?string, ResellerSourceName:?string, ResellerCompanyName:?string, ResellerSourceAddress:?string, CardExpirationDate:string, RetrievalReferenceNumber:?string, AssignedMerchantUsers:string[], AssignedResellerUsers:string[], CardTypeId:int, DigitalWalletId:?int, ResponseEventId:?string, ElectronicCommerceIndicator:?string, BinId:?string, Ucaf:?string, DualMessage:?string, AcquirerApproved:?string, AuthorizationId:?string, OrderServiceId:?string, ConnectedAccountId:?string, MerchantCategoryCode:?string, ServiceId:?string, ExternalTransactionId:?string, ApplicationIdentifierTerminal:?string, Descriptor:?string, ConversionRate:?float}'
TransactionArray: 'array{email:string, amount:float, orderCode:string, statusId:string, fullName:string, insDate:string, cardNumber:string, currencyCode:string, customerTrns:string, merchantTrns:?string, transactionTypeId:int, recurringSupport:bool, totalInstallments:int, cardCountryCode:?string, cardIssuingBank:?string, currentInstallment:int, cardUniqueReference:?string, cardTypeId:int, digitalWalletId:?int, bankId:string, switching:bool}'
WebhookEventDataArray: 'TransactionPaymentCreatedArray|TransactionFailedArray|array<string,mixed>'
WebhookEventArray: 'array{Url:string, EventData:WebhookEventDataArray, Created:string, CorrelationId:string, EventTypeId:int, Delay:?string, MessageId:string, RecipientId:string, MessageTypeId:int}'
Expand Down
2 changes: 1 addition & 1 deletion src/Events/TransactionFailed.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function __construct(
public readonly ?string $ParentId,
public readonly float $Amount,
public readonly string $ChannelId,
public readonly int $TerminalId,
public readonly ?int $TerminalId,
public readonly string $MerchantId,
public readonly string $OrderCode,
public readonly ?string $ProductId,
Expand Down
2 changes: 1 addition & 1 deletion src/Events/TransactionPaymentCreated.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function __construct(
public readonly ?string $ParentId,
public readonly float $Amount,
public readonly string $ChannelId,
public readonly int $TerminalId,
public readonly ?int $TerminalId,
public readonly string $MerchantId,
public readonly string $OrderCode,
public readonly ?string $ProductId,
Expand Down

0 comments on commit 948d562

Please sign in to comment.