Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use kubernetes lease election for Trillian log signer #851

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: use kubernetes lease election for Trillian log signer #851

wants to merge 1 commit into from
+47 −4

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Feb 12, 2025 •
edited
Loading

PoC uses latest build of upstream Trillian log signer

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman osmman force-pushed the tturek/trillian-k8s-election branch from 8deaa46 to b9ca11d Compare February 12, 2025 10:22
@osmman
Copy link
Contributor Author

osmman commented Feb 12, 2025

/test all

@osmman osmman force-pushed the tturek/trillian-k8s-election branch from b9ca11d to 42e53f0 Compare February 12, 2025 10:29
osmman
osmman commented Feb 12, 2025
View reviewed changes
internal/controller/constants/images.go
@@ -1,7 +1,7 @@
package constants

var (
TrillianLogSignerImage = "registry.redhat.io/rhtas/trillian-logsigner-rhel9@sha256:2d707d12e4f65e1a92b4de11465a5976d55e15ad6c9fefe994646ccd44c83840"
TrillianLogSignerImage = "gcr.io/trillian-opensource-ci/log_signer:latest"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary, it need to be changed before merge.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@osmman @openshift-merge-robot