-
Notifications
You must be signed in to change notification settings - Fork 3
Add track function and update page function. #10
Conversation
Updated Segment integration for new Appcues SDK
improved docs
Current coverage is 95.00% (diff: 100%)@@ master #10 diff @@
==========================================
Files 1 1
Lines 18 20 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 17 19 +2
Misses 1 1
Partials 0 0
|
analytics.called(window.Appcues.start); | ||
it('should call Appcues.page', function() { | ||
analytics.page('some page', { someAttr: true }); | ||
analytics.called(window.Appcues.page, 'some page'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should verify someAttr: true
is sent as well.
Added an assertion to the test to verify that |
Anything we can do on our side to help move this along? Thanks! |
@f2prateek any update for us here? We have a few mutual customers who are patiently waiting for this fix. |
@rayd @hijonathan sorry I didn't realize my initial comment had been addressed. LGTM. |
We're one of the customers waiting for a fix 👍 Look forward to seeing this resolved! |
Appcues now supports a track() function and a fuller page() implementation.