Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Add track function and update page function. #10

Merged
merged 10 commits into from
Sep 19, 2016

Conversation

rayd
Copy link
Contributor

@rayd rayd commented Sep 1, 2016

Appcues now supports a track() function and a fuller page() implementation.

@codecov-io
Copy link

codecov-io commented Sep 1, 2016

Current coverage is 95.00% (diff: 100%)

Merging #10 into master will increase coverage by 0.55%

@@             master        #10   diff @@
==========================================
  Files             1          1          
  Lines            18         20     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             17         19     +2   
  Misses            1          1          
  Partials          0          0          

Powered by Codecov. Last update bfb127c...0b95070

analytics.called(window.Appcues.start);
it('should call Appcues.page', function() {
analytics.page('some page', { someAttr: true });
analytics.called(window.Appcues.page, 'some page');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should verify someAttr: true is sent as well.

@rayd
Copy link
Contributor Author

rayd commented Sep 6, 2016

Added an assertion to the test to verify that someAttr is being passed. There's a handful of other properties that are passed along in the second arg (by analytics.page) and I didn't want to make assumptions about what those might be, so I'm directly checking the args property of the Appcues.page spy for the someAttr value. Does that seem like the right approach?

@rayd
Copy link
Contributor Author

rayd commented Sep 15, 2016

Anything we can do on our side to help move this along? Thanks!

@hijonathan
Copy link
Contributor

@f2prateek any update for us here? We have a few mutual customers who are patiently waiting for this fix.

@f2prateek
Copy link
Contributor

@rayd @hijonathan sorry I didn't realize my initial comment had been addressed. LGTM.

@f2prateek f2prateek merged commit d69fc94 into segment-integrations:master Sep 19, 2016
@SeedSultan
Copy link

We're one of the customers waiting for a fix 👍 Look forward to seeing this resolved!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants