Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Switch to the Sphinx Book Theme #153

Closed
wants to merge 24 commits into from
Closed

WIP: Switch to the Sphinx Book Theme #153

wants to merge 24 commits into from

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 2, 2021

Switch to the sphinx book theme but with minimal configurations.

@seisman seisman marked this pull request as draft February 2, 2021 05:50
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

This comment was written by the Continuous Documentation bot!

@core-man

This comment has been minimized.

@core-man

This comment has been minimized.

@core-man

This comment has been minimized.

@core-man

This comment has been minimized.

@zhaozhiyuan1989
Copy link
Member

这个主题对小图标支持是不是不太友好,:download: 之类的都不显示

@core-man

This comment has been minimized.

@seisman

This comment has been minimized.

@core-man

This comment has been minimized.

core-man added a commit that referenced this pull request Feb 3, 2021
@core-man

This comment has been minimized.

@core-man
Copy link
Member

core-man commented Feb 3, 2021

One con: when we browse down from the top, the left content will be missing. I hope it can always be there.

Screenshot from 2021-02-03 13-52-26

@seisman
Copy link
Member Author

seisman commented Feb 3, 2021

One con: when we browse down from the top, the left content will be missing. I hope it can always be there.

It works as you expect in their own site (https://sphinx-book-theme.readthedocs.io/en/latest/index.html). We may need to read the configurations.

@core-man
Copy link
Member

core-man commented Feb 3, 2021

Currently, we miss extern links:

Screenshot from 2021-02-03 14-09-18

Screenshot from 2021-02-03 14-10-20

See https://sphinx-book-theme.readthedocs.io/en/latest/configure.html#source-repository-buttons

  • seismo-learn main site
  • repo source code
  • contribution
  • Github Discussions

@seisman
Copy link
Member Author

seisman commented Feb 3, 2021

One con: when we browse down from the top, the left content will be missing. I hope it can always be there.

It works as you expect in their own site (https://sphinx-book-theme.readthedocs.io/en/latest/index.html). We may need to read the configurations.

Compatibility issue, see executablebooks/sphinx-panels#57

@seisman
Copy link
Member Author

seisman commented Feb 17, 2022

After migrating from sphinx-panels to sphinx-design, now the new theme looks great to me.

@core-man
Copy link
Member

core-man commented Feb 17, 2022

@seisman
Copy link
Member Author

seisman commented May 7, 2022

Closed by #507.

@seisman seisman closed this May 7, 2022
@seisman seisman deleted the sphinx-book-theme branch May 7, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants