Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base URL if window.location contains index.php #663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valioDOTch
Copy link

@valioDOTch valioDOTch commented Feb 21, 2017

I assume it was forgotten that the getBaseUrl regular expression should be adapted, after it was decided that index.html shall become index.php.

Currently I have to use a pretty ugly hack with the --body-html config

var getBaseUrl = Docs.controller.Content.prototype.getBaseUrl;
Docs.controller.Content.prototype.getBaseUrl = function(){
    var r = getBaseUrl.apply(this,arguments);
    r = r.replace('/index.php','');
    return r;
}

I assume it was forgotten that this replace part should be renamed, after it was decided that index.html shall become index.php.

Currently I have to use a pretty ugly hack with the --body-html config

```
var getBaseUrl = Docs.controller.Content.prototype.getBaseUrl;
Docs.controller.Content.prototype.getBaseUrl = function(){
    var r = getBaseUrl.apply(this,arguments);
    r = r.replace('/index.php','');
    return r;
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant