Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor #591

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Minor refactor #591

merged 3 commits into from
Feb 11, 2025

Conversation

alirezazolanvari
Copy link
Collaborator

What does this fix?

  • Eliminate single-line functions to reduce unnecessary function call overhead

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (1413a85) to head (f0faeef).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #591      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.00%     
==========================================
  Files          14       14              
  Lines        3187     3183       -4     
  Branches      433      433              
==========================================
- Hits         3177     3173       -4     
  Misses          4        4              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alirezazolanvari Thanks for your effort 💯
Please update the CHANGELOG.md file and add the html_init and html_end functions under the ### Removed section.

@sepandhaghighi sepandhaghighi added this to the PYCM 4.3 milestone Feb 4, 2025
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit 3fd038b into dev Feb 11, 2025
27 checks passed
@sepandhaghighi sepandhaghighi deleted the html_output_refactor branch February 11, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants