Refactor html color #592
Open
Refactor html color #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #592 +/- ##
==========================================
+ Coverage 99.69% 99.75% +0.07%
==========================================
Files 14 14
Lines 3183 3165 -18
Branches 433 426 -7
==========================================
- Hits 3173 3157 -16
Misses 4 4
+ Partials 6 4 -2 ☔ View full report in Codecov by Sentry. |
sepandhaghighi
requested changes
Feb 12, 2025
There was a problem hiding this comment.
@sadrasabouri Please update CHANGELOG.md.
- HTML generator engine modified
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR refactors the following functions:
html_dataset_type: the static part of the HTML template is moved toparams.py. That makes it easier to change and more maintainable. Also, the function is now much shorter.color_check: nested if statements reduced to one-line statements for easier readability (less indents)html_table_color: the equations for calculating the background color is now much simpler. A comprehensive list structure is now utilized instead of looping over thecolor_list.Any other comments?