Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace to secret creation heredoc #492

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Feb 27, 2025

The heredoc for creating a k8s token was missing a namespace, or at least it didn't match the rest of the docs that focus on the tower-nf namespace. This PR adds it so that it matches up.

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 431cba5
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/67c764c303b67e0008dc0267
😎 Deploy Preview https://deploy-preview-492--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gwright99
Copy link

gwright99 commented Feb 27, 2025

IMO adding an explicit namespace is always a good idea.

If you don't do that, it will either end up in the default namespace (bad) or - if you have customized your kubectl context to default to another namespace - it will go there instead.

IIRC I had this discussion with docs awhile ago on another ticket and there was a deliberate decision to not include it (I dont recall the reason). I'll see if I can dig up the link.

Edit: Here's the link: #133

@adamrtalbot
Copy link
Contributor Author

If you don't do that, it will either end up in the default namespace (bad) or - if you have customized your kubectl context to default to another namespace - it will go there instead.

When I followed the instructions, I did exactly this and it took me a hot minute to work it out.

Copy link

@gwright99 gwright99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my comment in the Conversation tab, this issue has been covered before and the resulting structure was a deliberate decision. Sticking to the sidelines and making no comment re: viability of this PR (despite my personal opinions).

@justinegeffen
Copy link
Contributor

Taking @gwright99's comments into account it would probably make sense to update this doc to better reflect the changes we made to the enterprise content last year. @adamrtalbot, would that work? The change is here: https://github.com/seqeralabs/docs/pull/133/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants