Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Allow Injection of Any PSR Cache Interface #966

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ceesvanegmond
Copy link
Contributor

PR Title:

Bugfix: Allow Injection of Any PSR Cache Interface

Description:

This PR introduces a fix to allow injection of any PSR-compatible CacheInterface, enhancing flexibility for users of the MobileDetect library. It also addresses an issue where cached values that return false or null could lead to unintended behavior.

Key Changes:

  • Switched from a specific cache implementation to the more generic CacheInterface.
  • Adjusted logic for handling cache results that could return falsy values.

Testing:

  • Verified with multiple cache interfaces to ensure compatibility.

@serbanghita serbanghita merged commit 920c549 into serbanghita:4.8.x Oct 3, 2024
5 checks passed
@serbanghita
Copy link
Owner

@ceesvanegmond thank you!

@serbanghita serbanghita self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants