Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GeoDB cities API #148

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add GeoDB cities API #148

wants to merge 1 commit into from

Conversation

Yizhou150
Copy link
Contributor

No description provided.

@Yizhou150 Yizhou150 linked an issue Apr 27, 2021 that may be closed by this pull request
Copy link
Contributor

@Wukkkinz-0725 Wukkkinz-0725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jessica,
Mostly, your geodb api looks good! I left 2 comments, which are not necessary to solve. When you finished that, let me know, then we can merge it.

</details>

<details>
<summary>What's the detail information of New York CIty?</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be New York City.

</details>

<details>
<summary>Get all regions with name start with "C" in a United States</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it will be better to use question sentence or not haha.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, I think sometimes directly using get ... is good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GeoDB API
2 participants