Fix $map query transform, add tests for $map and $explain #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharedb-mongo includes and runs all tests from sharedb core, and one of the core tests requires rich-text to be installed.
This was referenced Feb 13, 2024
alecgibson
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding tests for
$mapand$explainin queries in #152, I found out that$mapdoesn't actually work. It just hangs since the cursor is never traversed for results.This fixes
$mapby adding atoArray(). The results are delivered in theextracallback parameter, since the mapping function could map to something that's not a Mongo document, which would violate sharedb's assumptions aroundresultsbeing an array of Mongo docs.I also added a test for
$explain.