Resolves asgrim#36

siberia · Feb 3, 2020 · 1733397 · 1733397
1 parent 05b8ba7
commit 1733397
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -37,7 +37,7 @@ Most common nodes are support. If you come across an inaccessible node in your O
 
 ## Investments Support
 
-Investments look much different than bank / credit card transactions. This version supports a subset of the nodes in the OFX 2.0.3 spec, per the immediate needs of the author(s). You may want to reference the OFX documentation if you choose to implement this library.
+Investments look much different than bank / credit card transactions. This version supports a subset of the nodes in the OFX 2.0.3 spec, per the immediate needs of the author(s). You may want to reference the OFX documentation if you choose to implement this library. In particular, this does not currently process investment positions (INVPOSLIST) or referenced security definitions (SECINFO).
 
 This is not a pure pass-through of fields, such as this implementation in python: [csingley/ofxtools](https://github.com/csingley/ofxtools). This package contains fields that have been "translated" on occasion to make it more friendly to those less-familiar with the investments OFX spec.
 
@@ -48,7 +48,7 @@ To load investments from a Quicken (QFX) file or a MS Money (OFX / XML) file:
 use OfxParser\Entities\Investment as InvEntities;
 
 // Load the OFX file
-$ofxParser = new \OfxParser\Parser();
+$ofxParser = new \OfxParser\Parsers\Investment();
 $ofx = $ofxParser->loadFromFile('/path/to/your/investments_file.ofx');
 
 // Loop over investment accounts (named bankAccounts from base lib)

diff --git a/tests/OfxParser/ParserTest.php b/tests/OfxParser/ParserTest.php
@@ -219,6 +219,7 @@ public function loadFromStringProvider()
             'ofxdata-memoWithQuotes.ofx' => [dirname(__DIR__).'/fixtures/ofxdata-memoWithQuotes.ofx'],
             'ofxdata-emptyDateTime.ofx' => [dirname(__DIR__).'/fixtures/ofxdata-emptyDateTime.ofx'],
             'ofxdata-memoWithAmpersand.ofx' => [dirname(__DIR__).'/fixtures/ofxdata-memoWithAmpersand.ofx'],
+            'ofxdata-banking-xml200.ofx' => [dirname(__DIR__).'/fixtures/ofxdata-banking-xml200.ofx'],
         ];
     }
 

diff --git a/tests/fixtures/ofxdata-banking-xml200.ofx b/tests/fixtures/ofxdata-banking-xml200.ofx
@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="US-ASCII" standalone="no"?>
+<?OFX OFXHEADER="200" VERSION="200" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE"?>
+
+<OFX>
+<SIGNONMSGSRSV1>
+<SONRS>
+<STATUS>
+<CODE>0</CODE>
+<SEVERITY>INFO</SEVERITY>
+</STATUS>
+<DTSERVER>20170116031051</DTSERVER>
+<LANGUAGE>ENG</LANGUAGE>
+</SONRS>
+</SIGNONMSGSRSV1>
+<BANKMSGSRSV1>
+<STMTTRNRS>
+<TRNUID>0</TRNUID>
+<STATUS>
+<CODE>0</CODE>
+<SEVERITY>INFO</SEVERITY>
+</STATUS>
+<STMTRS>
+<CURDEF>ZAR</CURDEF>
+<BANKACCTFROM>
+<BANKID>000000</BANKID>
+<ACCTID>12345678901</ACCTID>
+<ACCTTYPE>CHECKING</ACCTTYPE>
+</BANKACCTFROM>
+<BANKTRANLIST>
+<DTSTART>20170109</DTSTART>
+<DTEND>20170116</DTEND>
+<STMTTRN>
+*snipped*
+</STMTTRN>
+</BANKTRANLIST>
+<LEDGERBAL>
+<BALAMT>1234.56</BALAMT>
+<DTASOF>20170116</DTASOF>
+</LEDGERBAL>
+</STMTRS>
+</STMTTRNRS>
+</BANKMSGSRSV1>
+</OFX>