Fix unit tests for investment transactions

siberia · Feb 3, 2020 · 8a15c39 · 8a15c39
1 parent 3a4f46c
commit 8a15c39
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/tests/OfxParser/Parsers/InvestmentTest.php b/tests/OfxParser/Parsers/InvestmentTest.php
@@ -93,7 +93,7 @@ public function testParseInvestmentsXML()
             self::assertTrue(count($account->statement->transactions) > 0);
         }
 
-        $this->validateTransactions($account->statement->transactions);
+        $this->validateTransactions($account->statement->transactions, $expected);
     }
 
     public function testParseInvestmentsXMLOneLine()
@@ -125,7 +125,7 @@ public function testParseInvestmentsXMLOneLine()
             self::assertTrue(count($account->statement->transactions) > 0);
         }
 
-        $this->validateTransactions($account->statement->transactions);
+        $this->validateTransactions($account->statement->transactions, $expected);
     }
 
     public function testParseInvestmentsXMLMultipleAccounts()
@@ -170,7 +170,11 @@ public function testParseInvestmentsXMLMultipleAccounts()
         }
 
         foreach ($ofx->bankAccounts as $account) {
-            $this->validateTransactions($account->statement->transactions);
+            $myExpected = isset($expected[$account->accountNumber])
+                ? $expected[$account->accountNumber]
+                : array();
+
+            $this->validateTransactions($account->statement->transactions, $myExpected);
         }
     }
 
@@ -202,10 +206,10 @@ public function testGoogleFinanceInvestments()
             self::assertTrue(count($account->statement->transactions) > 0);
         }
 
-        $this->validateTransactions($account->statement->transactions);
+        $this->validateTransactions($account->statement->transactions, $expected);
     }
 
-    protected function validateTransactions($transactions)
+    protected function validateTransactions($transactions, $expected)
     {
         foreach ($transactions as $t) {
             if (isset($expected[$t->uniqueId])) {