New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: farthest compare logic #45

Open

caijf wants to merge 1 commit into siege-media:gh-pages from caijf:patch-1

caijf commented Nov 19, 2021

No description provided.


          fix: farthest compare logic

1444e35

Collaborator

LeaVerou commented Nov 19, 2021

Hey, thanks! Which bug does this fix?

Author

caijf commented Nov 19, 2021

var max = Math.max(contrastOnBlack, contrastOnWhite);
// ...

return {
  // ...
  farthest: onWhite == max? _.WHITE : _.BLACK
}

onWhite == max The conditional judgment here is always no. I think it should be contrastOnWhite == max .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet