Subnet service #115
Merged
Subnet service #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| error!(?err, subnet = *subnet, "can't subscribe"); | ||
| } | ||
| self.swarm |
There was a problem hiding this comment.
Interestingly, Lighthouse doesn't do that. There could be a check somewhere else (PeerManager?) that keeps the target number of peers for each subnet.
There was a problem hiding this comment.
Yeah, I think we should check the peer_store before trying to discover. Will add this in my simplified peer manager PR.
Zacholme7
reviewed
Jan 23, 2025
dknopik
force-pushed
the
subnet_service
branch
from
6849e86 to
af77b69
Compare
|
Pushed a new design based on #117. Also pulled out the logic from |
Co-authored-by: diegomrsantos <[email protected]>
dknopik
force-pushed
the
subnet_service
branch
from
82a062c to
4b5e32f
Compare
diegomrsantos
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Small service that gets notified when a validator gets added or removed and passes on instructions to subscribe/unsubscribe/look for peers