Commit aggregation #136
Merged
Commit aggregation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacholme7
added
enhancement
dknopik
reviewed
Feb 13, 2025
dknopik
reviewed
Feb 13, 2025
dknopik
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Part of #103
Proposed Changes
This PR introduces commit message aggregation, aka decided messages. This is just the aggregation portion of the PR, the next step is to implement handling for this message type.
A aggregated commit message is just a quorum of commit messages where all of the signatures and operators are joined into one message. Instead of creating a whole new message, I just aggregate this all into the first commit message of the quorum. This also has to be broadcasted into the network so relevant manager functionality is also added.