Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handshake followup #138

Merged
merged 9 commits into from
Feb 17, 2025
Merged

Handshake followup #138

merged 9 commits into from
Feb 17, 2025

Conversation

dknopik
Copy link
Member

@dknopik dknopik commented Feb 14, 2025

follow up on #125 to discuss some changes proposed in that PR

@dknopik dknopik added ready-for-review This PR is ready to be reviewed network labels Feb 14, 2025
@dknopik dknopik requested a review from jxs February 14, 2025 13:25
jxs
jxs previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good Daniel! Thanks for working on it.
Left some suggestions, feel free to address them as you deem

@dknopik @jxs
address review
a2c4e43 
Co-authored-by: João Oliveira <[email protected]>
jxs
jxs approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Daniel!

@dknopik dknopik merged commit 7378fc0 into sigp:unstable Feb 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
network ready-for-review This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dknopik @jxs