Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature mismatch fix #142

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Signature mismatch fix #142

merged 1 commit into from
Feb 17, 2025

Conversation

Zacholme7
Copy link
Member

Issue Addressed

#141

Proposed Changes

Maintain id <-> signature pairing when sorting

@Zacholme7 Zacholme7 added ready-for-review This PR is ready to be reviewed QBFT labels Feb 14, 2025
dknopik
dknopik approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@dknopik dknopik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@dknopik dknopik merged commit f5c09c8 into sigp:unstable Feb 17, 2025
10 checks passed
@Zacholme7 Zacholme7 deleted the agg-fix branch February 17, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dknopik dknopik dknopik approved these changes

Assignees
No one assigned
Labels
QBFT ready-for-review This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zacholme7 @dknopik