-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SignedSSVMessage and SSVMessage validation #160
Open
diegomrsantos
wants to merge
7
commits into
sigp:unstable
Choose a base branch
from
diegomrsantos:signed-ssv-message-validation
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SignedSSVMessage and SSVMessage validation #160
diegomrsantos
wants to merge
7
commits into
sigp:unstable
from
diegomrsantos:signed-ssv-message-validation
+676
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99307f9
to
cf10d55
Compare
cf10d55
to
f9f80a9
Compare
6a64b81
to
ca76591
Compare
dknopik
reviewed
Feb 27, 2025
Zacholme7
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good on my end! Gj. I like the detailed validation errors. These will be good in the qbft crate too. Ill let kingy give this a glad too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
It's related to #161
Proposed Changes
We move basic validation inside the messages
Additional Info
This is only the first phase of validation, more PRs will come.