Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile bugs #209

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Fix profile bugs #209

merged 6 commits into from
Jan 22, 2025

Conversation

hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Jan 22, 2025 •
edited
Loading

IDP-547 When I added Printable Code, it then asked if I wanted to add a USB key (even though I had three by that time in the workflow.)

Fixed

  • fix skipping security key step if mfa < 3
  • fix not marking steps complete
  • fix id of undefined error if steps not initialized for 2sv intro

Feature branch checklist

  • Documentation (README, etc.)
  • Run make format and make depsupdate

@hobbitronics hobbitronics requested a review from a team as a code owner January 22, 2025 06:03
@hobbitronics hobbitronics requested review from briskt, forevermatt, mtompset and jason-jackson and removed request for a team January 22, 2025 06:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hobbitronics hobbitronics merged commit e06db7a into main Jan 22, 2025
3 checks passed
@hobbitronics hobbitronics deleted the fix-profile-bugs branch January 22, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/js-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/js-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/js-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobbitronics @briskt